Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_underscores option #76

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Add use_underscores option #76

merged 4 commits into from
Sep 26, 2023

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Sep 26, 2023

Previously: field_a => --field-a.
After setting use_underscores=True: field_a => --field_a

Addresses #75!

cc @vwxyzjn

@vwxyzjn
Copy link
Contributor

vwxyzjn commented Sep 26, 2023

Tried it out real quick and it's working as expected!
image

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c31ff2d) 99.13% compared to head (24d75ab) 99.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   99.13%   99.14%           
=======================================
  Files          23       23           
  Lines        1975     1993   +18     
=======================================
+ Hits         1958     1976   +18     
  Misses         17       17           
Flag Coverage Δ
unittests 99.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tyro/_arguments.py 100.00% <100.00%> (ø)
tyro/_cli.py 100.00% <100.00%> (ø)
tyro/_strings.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentyi brentyi enabled auto-merge (squash) September 26, 2023 18:52
@brentyi brentyi merged commit e73fbd2 into main Sep 26, 2023
10 checks passed
@brentyi brentyi deleted the brent/use_underscores branch September 26, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants